]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
status/network: Some minor style fixes
authorFlorian Müllner <fmuellner@gnome.org>
Sun, 7 Aug 2022 20:09:23 +0000 (22:09 +0200)
committerFlorian Müllner <fmuellner@gnome.org>
Sun, 7 Aug 2022 20:41:09 +0000 (22:41 +0200)
I wasn't genuiously going to touch those lines, but I ran into
a limitation of the run-eslint script:

It currently bases changed lines on a diff between HEAD and main
instead of the commit-by-commit log.

The two can vary quite a bit when shuffling code around, and those
are the lines the tool kept complaining about.

I'll look into improving the script, but for now it's quicker to
just shut it up by fixing up the complaints.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/2406>

js/ui/status/network.js

index 9a3a06a2f5d83d067aa20cd3b31dbddf974936db..6c374b20687f2e9c77a1b4c28ec33f93bb69f16e 100644 (file)
@@ -410,7 +410,7 @@ var NMConnectionDevice = class NMConnectionDevice extends NMConnectionSection {
 
     _sync() {
         let nItems = this._connectionItems.size;
-        this._autoConnectItem.visible = nItems == 0;
+        this._autoConnectItem.visible = nItems === 0;
         this._deactivateItem.visible = this._device.state > NM.DeviceState.DISCONNECTED;
 
         if (this._activeConnection == null) {
@@ -1392,10 +1392,10 @@ var NMDeviceWireless = class extends Signals.EventEmitter {
     }
 
     _canReachInternet() {
-        if (this._client.primary_connection != this._device.active_connection)
+        if (this._client.primary_connection !== this._device.active_connection)
             return true;
 
-        return this._client.connectivity == NM.ConnectivityState.FULL;
+        return this._client.connectivity === NM.ConnectivityState.FULL;
     }
 
     _isHotSpotMaster() {
@@ -1410,7 +1410,7 @@ var NMDeviceWireless = class extends Signals.EventEmitter {
         if (!ip4config)
             return false;
 
-        return ip4config.get_method() == NM.SETTING_IP4_CONFIG_METHOD_SHARED;
+        return ip4config.get_method() === NM.SETTING_IP4_CONFIG_METHOD_SHARED;
     }
 
     getIndicatorIcon() {
@@ -1995,8 +1995,8 @@ class Indicator extends PanelMenu.SystemIndicator {
     }
 
     _mainConnectionStateChanged() {
-        if (this._mainConnection.state == NM.ActiveConnectionState.ACTIVATED && this._notification)
-            this._notification.destroy();
+        if (this._mainConnection.state === NM.ActiveConnectionState.ACTIVATED)
+            this._notification?.destroy();
     }
 
     _ignoreConnection(connection) {